gl326 / bard-audio

An engine for designing and implementing good audio in Game Maker Studio 2. Please see the wiki for more info! https://github.com/gl326/bard-audio/wiki
MIT License
39 stars 2 forks source link

Error when trying to boot into rmAudio editor when adding Bard Engine to a project #1

Closed SolidplasmaStudios closed 2 years ago

SolidplasmaStudios commented 2 years ago

This is for the GMS 2 beta (2022.600.0.143) with rollback netcode, which I have not yet used.

When run normally:

ERROR in action number 1 of Other Event: User Defined 10 for object objAudioEditor:

JSON parse error at gml_Object_objAudioEditor_Other_20 (line 3) - var project_data = json_parse(file_read_string(project_file)); //get data from project ############################################################################################ gml_Object_objAudioEditor_Other_20 (line 3) gml_Object_objAudioEditor_Create_0 (line 81)

When run in Debug Mode:


############################################################################################ ERROR in action number 1 of Create Event for object :

global variable name 'project_directory' index (100641) not set before reading it. at gml_Scriptget_project (line 34) - if (global.project_directory == undefined) ############################################################################################ gml_Scriptget_project (line 34) gml_Script_get_project_directory (line 8) - _get_project(); gml_Script_get_datafiles_directory (line 7) - global.__project_datafiles = get_project_directory() + "datafiles\"; gml_Script_bard_audio_data_load (line 5) - var _path = get_datafiles_directory()+_filename; gml_GlobalScript_bard_audio_system (line 326) - bard_audio_data_load();

Probably a bug with the new version of game maker, but lemme know if there'd be a workaround. I'd love to prototype my multiplayer rhythm game with the rollback netcode!

gl326 commented 2 years ago

hey! try running in debug mode. sorry about that

On Fri, Jul 1, 2022 at 11:11 PM SolidplasmaStudios @.***> wrote:

This is for the GMS 2 beta (2022.600.0.143) with rollback netcode, which I have not yet used.

When run normally:

ERROR in action number 1 of Other Event: User Defined 10 for object objAudioEditor:

JSON parse error at gml_Object_objAudioEditor_Other_20 (line 3) - var project_data = json_parse(file_read_string(project_file)); //get data from project

############################################################################################ gml_Object_objAudioEditor_Other_20 (line 3) gml_Object_objAudioEditor_Create_0 (line 81)

When run in Debug Mode:

############################################################################################ ERROR in action number 1 of Create Event for object :

global variable name 'project_directory' index (100641) not set before reading it. at gml_Scriptget_project (line 34) - if (global.__project_directory == undefined)

############################################################################################ gml_Script__get_project (line 34) gml_Script_get_project_directory (line 8) - _get_project(); gml_Script_get_datafiles_directory (line 7) - global.__project_datafiles = get_project_directory() + "datafiles\"; gml_Script_bard_audio_data_load (line 5) - var _path = get_datafiles_directory()+_filename; gml_GlobalScript_bard_audio_system (line 326) - bard_audio_data_load();

Probably a bug with the new version of game maker, but lemme know if there'd be a workaround. I'd love to prototype my multiplayer rhythm game with the rollback netcode!

— Reply to this email directly, view it on GitHub https://github.com/gl326/bard-audio/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3KFZRQFAQUTSEW3RV3ZADVR7MQRANCNFSM52ORWDHQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

SolidplasmaStudios commented 2 years ago

Hey, thanks for the quick response. When trying in debug, I get the second error I posted, there are actually two there. Also upon loading the project, there's an empty object with no referenceID in the rmAudioEditor. I don't know if it's related.

SolidplasmaStudios commented 2 years ago

Getting the same errors as above in the non-beta version, Game Maker ver 2.3.589. When I run the extension without merging it with my project in the beta build I used before, I get an empty black screen.

gl326 commented 2 years ago

hi there, i am posting a new release shortly and as far as i can tell this error isn't in it. the code errors you show don't make a ton of sense to me because they don't actually match what is written in the code i am looking at. so, i guess try the new one out and see how it goes!

On Mon, Jul 4, 2022 at 6:38 AM SolidplasmaStudios @.***> wrote:

Getting the same errors as above in the non-beta version, Game Maker ver 2.3.589. When I run the extension without merging it with my project in the beta build I used before, I get an empty black screen.

— Reply to this email directly, view it on GitHub https://github.com/gl326/bard-audio/issues/1#issuecomment-1173833464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3KFZW4DT6TDDGAAFVXMQ3VSLSLXANCNFSM52ORWDHQ . You are receiving this because you commented.Message ID: @.***>

SolidplasmaStudios commented 2 years ago

Hi, thank you so much for the update! So when I import the engine into my project, and disable the fiie system sandbox, it now launches in debug mode when I make rmAudioEditor the first room, but I still get the first error above when I launch the game regularly. Is this intended behavior?

gl326 commented 2 years ago

Ah, that I should fix! That said, the audio editor should never ever be exposed to a player, only devs. Never noticed this because I only let the game visit that room when in debug mode 😝

On Sun, Jul 10, 2022 at 4:07 AM SolidplasmaStudios @.***> wrote:

Hi, thank you so much for the update! So when I import the engine into my project, and disable the fiie system sandbox, it now launches in debug mode when I make rmAudioEditor the first room, but I still get the first error above when I launch the game regularly. Is this intended behavior?

— Reply to this email directly, view it on GitHub https://github.com/gl326/bard-audio/issues/1#issuecomment-1179706762, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3KFZWNH22NOXZDM72D6G3VTKVHVANCNFSM52ORWDHQ . You are receiving this because you commented.Message ID: @.***>