gl91306 / lunar

15 stars 5 forks source link

lwjgl3 arm64 zip not using 16K pagesize compatible jemalloc #43

Open theofficialgman opened 9 months ago

theofficialgman commented 9 months ago

Describe the bug

the lwjgl3 zip found on this repo is out of date and not using the 16K pagesize compatible jemalloc

I am not going to decompile this client to see how the zips are using for the various minecraft versions but you should be aware that different versions should use different versions of lwjgl3 as specified by the mojang json (3.1.6, 3.2.1, 3.2.2, 3.3.1, and 3.3.2). upstream support for 16K pagesize compatible jemalloc came in lwjgl 3.3.2

gl91306 commented 9 months ago

As far as I am aware, the only lwjgl versions that should match with minecraft versions is lwjgl2 = minecraft 1.12 and less, while lwjgl3 = minecraft 1.13 and above. Could you provide where u got the data for the lwjgl versions corresponding to Minecraft versions? Ive never had any issues with any minecraft versions above 1.13 not being able to launch with the version on this repo, is it a performance issue?

theofficialgman commented 9 months ago

As far as I am aware, the only lwjgl versions that should match with minecraft versions is lwjgl2 = minecraft 1.12 and less, while lwjgl3 = minecraft 1.13 and above. Could you provide where u got the data for the lwjgl versions corresponding to Minecraft versions? Ive never had any issues with any minecraft versions above 1.13 not being able to launch with the version on this repo, is it a performance issue?

sigh... I've explained this to you before. Each version of lwjgl 3 has many API changes. Some break the base game themselves and some break mods (eg sodium) that expect one API while you falsely present it with another.

Use the version that mojang specifies in their json

gl91306 commented 9 months ago

bruh. even if you explained this to me before its litteraly been 2 years.

im busy rn so ill only work on the lwjgl3 multiswitching later.

also, in refrence to the commit you added on it being broken on bookworm/pi5, the installscript you have for lunar on pi-apps is litteraly 2 versions off

theofficialgman commented 9 months ago

also, in refrence to the commit you added on it being broken on bookworm/pi5, the installscript you have for lunar on pi-apps is litteraly 2 versions off

there is no auto-updater for lunar client implemented and the maintainer of the client did not notify or PR an update

Botspot commented 2 months ago

@theofficialgman has had Lunar Client hidden on Pi-Apps for 7 months due to this issue. https://github.com/Botspot/pi-apps/commit/cd57a5ce88f6117db591734476250d7b2db198c6 What can we do to get it back in 100% working order and returned to its expected place in the Pi-Apps list?

People keep asking where it is when they can't find it.

theofficialgman commented 2 months ago

@theofficialgman has had Lunar Client hidden on Pi-Apps for 7 months due to this issue. Botspot/pi-apps@cd57a5c What can we do to get it back in 100% working order and returned to its expected place in the Pi-Apps list?

People keep asking where it is when they can't find it.

That's only one of the list of broken things. You can't just use one version of lwjgl for every Minecraft release (like this lunar fork does). I've already explained that ad nauseum.

It was never in 100% in working order and likely never will be. I have no interest in a launcher that introduces game breaking bugs. We have launchers that are better in every single way, there isn't a need for more.

Botspot commented 2 months ago

Then let's remove it unless @gl91306 protests and can show something Lunar can do that the other launchers cannot.

theofficialgman commented 2 months ago

Now is the time to remove it especially with the lunar client selling out to overwolf just a few days ago. That is fine with me.

Given their launchers complexity and closed source nature arm support in lunar will never be feasible long term from a 3rd party (eg: gl91306)

gl91306 commented 2 months ago

Ok to start I have zero issue with you guys removing lunar from pi-apps, and I was about to just ignore this github-email notification till I saw this:

Then let's remove it unless @gl91306 protests and can show something Lunar can do that the other launchers cannot.

I thought I have made it abundandtly clear that I did not want lunar in pi-apps.

Heres a comment from this repo from a few years ago

I had previously added issues to add both Godot Engine and Deltarune to pi-apps, but they weren't added within a week. That's when I discovered pi-ware. There were only like 7 people in the discord at the time, and I liked the small community. Right after I asked, both of my apps were instantly added to pi-ware. From there on, I started contributing to the main code, and became part of the pi-ware team. And when I got lunar to first run its startup screen, I had thought to add this to pi-ware. I also thought (like you) that I should add this to pi-apps, so I went in the discord and showed the screenshots, they thought it was cool. But when I told them that lunar was closed source, and I had decompiled it, they deleted my messages. I then added the app to pi-ware, and they had no problems. So from there on, the only reason I continued developing lunar for the raspberry pi, was to add it to pi-ware. I dont care about advancement or userspace. Its kind of personal thing at this point, but I don't think lunar should be added to pi-apps. My final reason is that pi-ware is a small community, and the only way to let it grow, is to add popular apps to it. But if lunar is available in pi-apps and pi-ware, the pi-ware community wont grow. Also, if you really want lunar in pi-apps, then technichicly, then this issue might work. here. So yeah :P

And here

:P

wait so ur abandoning lunar D: ?

lmao noo. Id never abandon it. I just really dont care if its on pi-apps. Its a pi-ware exclusive, so if it gets removed from here i really dont care

image

image

image

image

image

image

image

image

Now sorry for being petty and pulling out every instance of evidence, but as you have seen, I reluctantly allowed it on pi-apps, and have been asking since for it to be removed.

This is something that is years old, and I was well past this whole thing and have still tried my level best to fix bugs on lunar as they popped up, albeit more slowly as time has gone on.

And at the end bro I really do not care if you remove this from pi-apps.

But I will not simply stand for you assuming I would "protest and can show something Lunar can do that the other launchers cannot" as I find that frankly, very insulting.

I don't wanna harbor any hate or anything but I wanted to express what I felt rather than just let this slide.

peace ❤️

Botspot commented 2 months ago

Understand.

But I will not simply stand for you assuming I would "protest and can show something Lunar can do that the other launchers cannot" as I find that frankly, very insulting.

I don't wanna harbor any hate or anything but I wanted to express what I felt rather than just let this slide.

Wow, I never expected that to be taken wrongly. I thought it would be nice to give you the opportunity to say "wait guys, actually Lunar can do X and Y that the other minecraft launchers cannot - for those reasons I suggest either adding Lunar back or implementing features X and Y in another launcher, for the benefit of the users."

I never want to be the person who makes impulsive decisions, before giving everybody a chance to share their perspective. That was all I was trying to ask from you: your perspective, so that you could be heard and your wishes honored. We have removed Lunar Client from Pi-Apps. 👍

theofficialgman commented 2 months ago

Leaving this issue open since the problems it was opened for still exists.

I suggest archiving the repo to reflect your current status on this project. (It can always be unarchived)