search

glFusion / glfusion

glFusion CMS - Advanced Content Management with Style
https://www.glfusion.org
GNU General Public License v2.0
14 stars 15 forks source link

Delete syndication files when syndication is disabled. #468

Closed leegarner closed 2 years ago

leegarner commented 3 years ago

It seems to make sense when disabling a syndication feed to delete the related file from public_html/backend, since keeping it would continue to syndicate old data. When enabling, the file could be regenerated just as it is when editing and saving the feed.

leegarner commented 3 years ago

I'm wondering about another idea, which is only slightly more complex, which is to update SYND_updateFeed() and SYND_updateFeediCal() to create feed files with no data, only headers and footers. That would keep the feed valid but prevent data from being included.

mark0263 commented 2 years ago

I know you've done a lot of work on syndication - has this one been implemented?

leegarner commented 2 years ago

Implemented in 5b728e9bb71d185efbe6666727bdf4be3f5fc66c

leegarner commented 2 years ago

I was incorrect, the file is deleted when the feed is deleted, but not when the status changes. I submitted https://github.com/glFusion/glfusion/pull/505 to delete or update the feed when the status is changed.