search

glFusion / glfusion

glFusion CMS - Advanced Content Management with Style
https://www.glfusion.org
GNU General Public License v2.0
14 stars 15 forks source link

Add thread prefixes to forum topics #476

Open leegarner opened 3 years ago

leegarner commented 3 years ago

A popular forum feature is the "prefix" for thread topics, such as "For Sale", "Wanted", Sticky", etc. Usually these are styled with different colors and fonts.

Initial work being done on https://github.com/leegarner/glfusion/tree/ff_prefix_1

leegarner commented 3 years ago

Currently using simple HTML code similar to how MyBB implements prefixes. May update to use the advanced editor with a minimal set of font options.

leegarner commented 3 years ago

Question, Mark.... glFusion shows the topic subject in each reply with "RE" prepended to it. Some others show it only once...

I think I like the MyBB approach where the subject is shown once in the header. Might simplify multi-page threads, also.

mark0263 commented 2 years ago

I'm good with doing it just once - How exactly would that look? When I look at a long thread, the parent (first) topic does not have it - all replies do. So how would this look - would we remove the RE: from all replies, or just those after the first reply?

leegarner commented 2 years ago

I was thinking the subject could show once at the top of each page, instead of in each post, This is from MyBB, vBulletin puts the title in the first post and just omits it from others.

I haven't thought about long multi-page threads, but I guess we could get the first topic (pid = 0) and then the rest using LIMIT and j. I did notice that MyBB automatically stores the subject as "RE: original_subject" in replies and just doesn't show that field.

On Thu, Feb 3, 2022 at 8:29 AM Mark R. Evans @.***> wrote:

I'm good with doing it just once - How exactly would that look? When I look at a long thread, the parent (first) topic does not have it - all replies do. So how would this look - would we remove the RE: from all replies, or just those after the first reply?

— Reply to this email directly, view it on GitHub https://github.com/glFusion/glfusion/issues/476#issuecomment-1029168161, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYLFOJS5K3AAEZHAR5VUJDUZKUOPANCNFSM5HBO74BQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>

leegarner commented 2 years ago

I just did a little more fleshing out. Could use work but here's kind of what I was thinking. Then for replies we can just remove or hide the topic field"

https://gldev.leegarner.com/forum/viewtopic.php?showtopic=63

On Thu, Feb 3, 2022 at 9:33 AM Lee Garner @.***> wrote:

I was thinking the subject could show once at the top of each page, instead of in each post, This is from MyBB, vBulletin puts the title in the first post and just omits it from others.

I haven't thought about long multi-page threads, but I guess we could get the first topic (pid = 0) and then the rest using LIMIT and j. I did notice that MyBB automatically stores the subject as "RE: original_subject" in replies and just doesn't show that field.

On Thu, Feb 3, 2022 at 8:29 AM Mark R. Evans @.***> wrote:

I'm good with doing it just once - How exactly would that look? When I look at a long thread, the parent (first) topic does not have it - all replies do. So how would this look - would we remove the RE: from all replies, or just those after the first reply?

— Reply to this email directly, view it on GitHub https://github.com/glFusion/glfusion/issues/476#issuecomment-1029168161, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYLFOJS5K3AAEZHAR5VUJDUZKUOPANCNFSM5HBO74BQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>

mark0263 commented 2 years ago

To be honest, I actually prefer having the subject on each post. My thought is - as I scroll, the top post (with the subject) goes off the screen, since I'm always a little distracted anyway, I forget the actual subject as I continue to scroll and read. But that is just me...

Now the sticky, solved, etc. I like that , and it makes sense to just show on the initial post.

I really have no real preference on the subject per post - it works either way I think.

leegarner commented 2 years ago

You have a point, I just pushed some changes to my branch to do one subject but it would be simple to go back to showing in each topic. I got my branch kind of munged up from merging from develop, I'll get it sorted and let you look.

On Thu, Feb 3, 2022 at 10:43 AM Mark R. Evans @.***> wrote:

To be honest, I actually prefer having the subject on each post. My thought is - as I scroll, the top post (with the subject) goes off the screen, since I'm always a little distracted anyway, I forget the actual subject as I continue to scroll and read. But that is just me...

Now the sticky, solved, etc. I like that , and it makes sense to just show on the initial post.

I really have no real preference on the subject per post - it works either way I think.

— Reply to this email directly, view it on GitHub https://github.com/glFusion/glfusion/issues/476#issuecomment-1029290041, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYLFOINHQSD77F3ZMX5HS3UZLEDRANCNFSM5HBO74BQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>

leegarner commented 2 years ago

I'm not sure, here's an option that uses the topic and prefix from the parent topic and shows it in each reply (the top one is leftover from the previous idea.

On Thu, Feb 3, 2022 at 11:59 AM Lee Garner @.***> wrote:

You have a point, I just pushed some changes to my branch to do one subject but it would be simple to go back to showing in each topic. I got my branch kind of munged up from merging from develop, I'll get it sorted and let you look.

On Thu, Feb 3, 2022 at 10:43 AM Mark R. Evans @.***> wrote:

To be honest, I actually prefer having the subject on each post. My thought is - as I scroll, the top post (with the subject) goes off the screen, since I'm always a little distracted anyway, I forget the actual subject as I continue to scroll and read. But that is just me...

Now the sticky, solved, etc. I like that , and it makes sense to just show on the initial post.

I really have no real preference on the subject per post - it works either way I think.

— Reply to this email directly, view it on GitHub https://github.com/glFusion/glfusion/issues/476#issuecomment-1029290041, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYLFOINHQSD77F3ZMX5HS3UZLEDRANCNFSM5HBO74BQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>