Closed leegarner closed 2 years ago
Adding previously-omitted public_html/rater2_rpc.php rater2_rpc.php.txt
You're right, I missed that. I just updated the PR by attaching the file. I was keeping it separate during testing and planned to rename to rater_rpc.php but overlooked that, obviously.
On Wed, Jan 5, 2022 at 5:46 AM Mark R. Evans @.***> wrote:
Question: the JS now references rater2_rpc.php - I've updated to rater_rpc.php, but is is throwing an error on $item_id. Are there updates needed to rater_rpc.php?
— Reply to this email directly, view it on GitHub https://github.com/glFusion/glfusion/pull/490#issuecomment-1005698893, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYLFONB6APR74ZU4QQURTDUURDUDANCNFSM5LIMPW7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
It might require a new PR since I've already merged this one.
nevermind - I'll use the attachment.
Yeah, I tried a new PR but it wouldn't merge automatically for some reason, couldn't see why but figured the attachment is the easy way. I'll leave it to you whether to just drop it in or rename & update the template ;)
One minor thing I noticed, the extra line-break after voting could be removed for a little better layout.
100c100
< $message = '<br><span class="thanks"> ' . $LANG13['thanks_for_vote'] . '</span>';
---
> $message = '<span class="thanks"> ' . $LANG13['thanks_for_vote'] . '</span>';
Question: the JS now references rater2_rpc.php - I've updated to rater_rpc.php, but is is throwing an error on $item_id. Are there updates needed to rater_rpc.php?