glacambre / firenvim

Embed Neovim in Chrome, Firefox & others.
GNU General Public License v3.0
4.65k stars 143 forks source link

`Firenvim` triggers on the preview page (where it is not supposed tobe triggered) and not triggers on the editing page (where it is supposed to) be triggered) #1537

Closed Marin-Kitagawa closed 1 year ago

Marin-Kitagawa commented 1 year ago

Problem

OS Specification

Edition:    Windows 11 Pro
Version:    22H2
OS build:   22621.1702
Experience: Windows Feature Experience Pack 1000.22641.1000.0

What I tried to do

I am trying to edit the source code from within Github.

What happened

Firenvim works perfectly when trying to create new issues (i.e. in the issue textarea such as this one). But while trying to edit the source code (by clicking on the Edit this file button), I am not able to edit it using Firenvim. But before clicking on Edit this file button, if I click on the code preview page, it enters the edit mode using Firenvim

Expected function

Firenvim must fire only when the textarea supports editing i.e. not while previewing.

Screenshots

image


image

In the first screenshot, you can see that Firenvim enters into edit mode while I am just previewing. The repository indicated in the screenshot is not even mine and I don't have write access. So, Firenvim enters into edit mode while previewing.

Another problem is shown in the second screenshot. The problem is that Firenvim doesn't work where it is supposed to; while editing the source code from Github