search

glacambre / firenvim

Embed Neovim in Chrome, Firefox & others.
GNU General Public License v3.0
4.65k stars 143 forks source link

Fix chrome://extensions/shortcuts missing options #1539

Closed yvay closed 1 year ago

yvay commented 1 year ago

At least on Chromium 113.0.5672.126 (the current version in Fedora 37), command descriptions with strings that look like HTML tags (e.g. \<C-w>) prevent that option and all the options that follow from being shown in chrome://extensions/shortcuts.

Unknown tags, \<script> and probably others trigger this error. Some tags like \<b> don't trigger it but they are parsed as plaintext, so this looks like a Chromium bug.

Anyway, this patch replaces \<C-w> and similar with Ctrl-w allowing commands to be configured in chrome://extension/shorcuts. I tried escaping the original text but didn't find a way.

glacambre commented 1 year ago

Hi, thanks a lot for taking the time to dig into this and to figure out a fix! Sorry for not merging right away, I wanted to try something out and then forgot to merge :)

yvay commented 1 year ago

No problem! I use C-w all the time so when I didn't find the option to configure it I had to look into it.