glacambre / firenvim

Embed Neovim in Chrome, Firefox & others.
GNU General Public License v3.0
4.65k stars 143 forks source link

Firenvim is not working on Edge Canary #1558

Open Marin-Kitagawa opened 12 months ago

Marin-Kitagawa commented 12 months ago

What I tried to do

I tried to use Firenvim in Edge Canary

What happened

It throws an error saying that Neovim is not responding. But I could use Firenvim in Edge (stable).

glacambre commented 12 months ago

Hi, thanks for opening this issue. Edge canary currently isn't supported, but it shouldn't be too hard to add to Firenvim. I'll look into it.

Marin-Kitagawa commented 12 months ago

It is working now. I did these steps

  1. Copied firenvim-edge.json to firenvim-edge-sxs.json
  2. In the registry, I updated the NativeMessagingHosts for Edge SxS and pointed the value to $env:localappdata\firenvim\firenvim-edge-sxs.json
  3. Content of the above file wasn't changed
  4. firenvim.bat file was not modified

All the above steps are done after calling both :call firenvim#install(x) where $x\in \set{0,1}$.

I use Neovim with Astronvim. Below is my configuration for firenvim as in user/init.lua

return {
  plugins = {
    {
      'glacambre/firenvim',

      -- Lazy load firenvim
      -- Explanation: https://github.com/folke/lazy.nvim/discussions/463#discussioncomment-4819297
      lazy = false,
      build = function()
        vim.fn["firenvim#install"](0)
      end
    },
  }
}

Note: lazy = not vim.g.started_by_firenvim didn't work for me. So, I kept lazy = false Now, it is working.

glacambre commented 12 months ago

Wow, thank you for taking the time to figure out how to get Firenvim working on Edge Canary and for sharing them with me, very appreciated :). I'll try to find the time to incorporate your changes in the coming days.