update npm deps and fix issue with sharp 0.31.2 in alpine lts

glacambre / firenvim

Embed Neovim in Chrome, Firefox & others.

GNU General Public License v3.0

4.57k stars 144 forks source link

update npm deps and fix issue with sharp 0.31.2 in alpine lts #1573

Closed infokiller closed 6 months ago

infokiller commented 6 months ago

Hey @glacambre great to talk to you again and thanks for the quick response! Sorry for the failing CI and the merge noise, I will take a look later today (will try your patch of course- thanks a lot!).

infokiller commented 6 months ago

@glacambre thanks, indeed I didn't run npm install after npm update, which caused the issue. Now most of the CI tests pass, but two failed with "artifact expired". Is this benign?

glacambre commented 6 months ago

@infokiller Thanks! Yes, these failures can be ignored. The first one failed in the code coverage comparison step (it tries to compare the current run's coverage against the last run on master, which happened too long ago), the second one failed due to a flaky test :).