glacambre / firenvim

Embed Neovim in Chrome, Firefox & others.
GNU General Public License v3.0
4.68k stars 144 forks source link

Build failed during Lazy update #1629

Closed joshuadanpeterson closed 1 month ago

joshuadanpeterson commented 1 month ago

What I tried to do

I tried updating the plugin in Lazy

What happened

I got a build failed error message with this:

Vim:E117: Unknown function: firenvim#install

glacambre commented 1 month ago

Please provide steps to reproduce this issue from scratch, with a minimal init.lua.

gnomegl commented 1 month ago

I just installed this with Lazy as well for the first time and am experiencing the same issue.

The steps are just to test using Lazy.nvim to load the plugin. It fails during the build task with the following error:

Vim:E117: Unknown function: firenvim#install

I was able to get it working by going to ~/.local/share/nvim/lazy/firenvim and running

npm i && npm run build && npm run install_manifests

Now Lazy.nvim seems to be able to see that it's loaded.

Also note that when I run

echo 'abcde{}' | ${XDG_DATA_HOME:-${HOME}/.local/share}/firenvim/firenvim

I get this:

Tracking session in Session.vim{"messages": ["Tracking session in Session.vim"], "version": "0.2.16", "settings": {"localSettings": {".*": {}}, "globalSettings": {}}}Deleting session in Session.vim

I am using a plugin to manage my vim sessions. I don't know if that's what could be causing the install issue or not, I just thought it was worth mentioning.

glacambre commented 1 month ago

@gnomegl Thank you for spending some effort trying to find a solution. I updated the installation instructions, things seem to work on my machine.

joshuadanpeterson commented 1 month ago

Thank you @gnomegl and @glacambre! The fix you made for the installation instructions resolved the issue for me.