glacials / splits-io

a speedrunning data store and analysis engine
https://splits.io
GNU Affero General Public License v3.0
132 stars 26 forks source link

Show rival(s) higher on compare dropdown #728

Open glacials opened 4 years ago

glacials commented 4 years ago

From https://discordapp.com/channels/361957211318124555/527698018942582784/756806905912885288

BatedUrGonnaDie commented 4 years ago

I thought all of the rival code was removed?

glacials commented 4 years ago

Technically true! I removed the views and controller because they were unmaintained and the UX didn't feel right, with the intention to move to more of a rivalry-by-default view on the standard run page. That never happened, but the frontpage kept showing existing rivalries, so users asked for a way to change them. I added the below button as a stopgap in d92a709829bebeb12fe6ddf2c27cc307c287d19d, which changes between add/replace/remove based on state.

Untitled

(database / model code was never touched)