search

glacials / whatsinstandard

a Magic: The Gathering format reference
https://whatsinstandard.com
MIT License
130 stars 34 forks source link

Bans are incorrect #211

Closed Roudique closed 3 years ago

Roudique commented 3 years ago

After recent rotation, bans did not get updated in the API.

This is what's currently returned, note cards from Throne of Eldraine:

"bans": [
    {
      "cardName": "Oko, Thief of Crowns",
      "cardImageUrl": "https://img.scryfall.com/cards/png/front/3/4/3462a3d0-5552-49fa-9eb7-100960c55891.png",
      "setCode": "ELD",
      "reason": "Banned for its power level being higher than is healthy for current and future Standard metagame environments.",
      "announcementUrl": "https://magic.wizards.com/en/articles/archive/news/november-18-2019-banned-and-restricted-announcement"
    },
    {
      "cardName": "Once Upon a Time",
      "cardImageUrl": "https://img.scryfall.com/cards/png/front/4/0/4034e5ba-9974-43e3-bde7-8d9b4586c3a4.png",
      "setCode": "ELD",
      "reason": "Banned for contributing to a high consistency of strong starts for green, providing a level of early mana fixing that other colors don't have access to.",
      "announcementUrl": "https://magic.wizards.com/en/articles/archive/news/november-18-2019-banned-and-restricted-announcement"
    },
    {
      "cardName": "Fires of Invention",
      "cardImageUrl": "https://img.scryfall.com/cards/png/front/a/1/a12b16b0-f75f-42d8-9b24-947c1908e0f7.png",
      "setCode": "ELD",
      "reason": "Banned for introducing too many risks and design constraints to the future of Standard.",
      "announcementUrl": "https://magic.wizards.com/en/articles/archive/news/june-1-2020-banned-and-restricted-announcement"
    },
    {
      "cardName": "Cauldron Familiar",
      "cardImageUrl": "https://img.scryfall.com/cards/png/front/9/a/9a539a23-8383-4525-82dd-acfe1d219fe9.png",
      "setCode": "ELD",
      "reason": "Banned for reducing metagame diversity and for being cumbersome to play against.",
      "announcementUrl": "https://magic.wizards.com/en/articles/archive/news/august-8-2020-banned-and-restricted-announcement"
    },
    {
      "cardName": "Uro, Titan of Nature's Wrath",
      "cardImageUrl": "https://c1.scryfall.com/file/scryfall-cards/png/front/a/0/a0b6a71e-56cb-4d25-8f2b-7a4f1b60900d.png",
      "setCode": "THB",
      "reason": "Banned for weakening four-colour ramp decks.",
      "announcementUrl": "https://magic.wizards.com/en/articles/archive/news/september-28-2020-banned-and-restricted-announcement-2020-09-28"
    },
    {
      "cardName": "Omnath, Locus of Creation",
      "cardImageUrl": "https://c1.scryfall.com/file/scryfall-cards/large/front/4/e/4e4fb50c-a81f-44d3-93c5-fa9a0b37f617.jpg?1602499748",
      "setCode": "ZNR",
      "reason": "Banned for being too strong in four-color ramp decks.",
      "announcementUrl": "https://magic.wizards.com/en/articles/archive/news/october-12-2020-banned-and-restricted-announcement?adf"
    },
    {
      "cardName": "Lucky Clover",
      "cardImageUrl": "https://c1.scryfall.com/file/scryfall-cards/large/front/4/b/4b5d23a6-3a23-4169-aea1-f10bf5153180.jpg?1602499760",
      "setCode": "ELD",
      "reason": "Banned for being a powerful and difficult-to-interact-with part of Adventure decks.",
      "announcementUrl": "https://magic.wizards.com/en/articles/archive/news/october-12-2020-banned-and-restricted-announcement?adf"
    },
    {
      "cardName": "Escape to the Wilds",
      "cardImageUrl": "https://c1.scryfall.com/file/scryfall-cards/large/front/3/e/3e26c10b-179f-4a6e-bc8d-3ec1d6783fb9.jpg?1602499769",
      "setCode": "ELD",
      "reason": "Banned for being a unique and powerful bridge between strong ramp enablers and powerful payoffs.",
      "announcementUrl": "https://magic.wizards.com/en/articles/archive/news/october-12-2020-banned-and-restricted-announcement?adf"
    }
  ]
glacials commented 3 years ago

This is expected behavior for v6, see: https://github.com/glacials/whatsinstandard/tree/main/api#notes

However this is breaking v5 which never had this behavior, so I'd accept a pull request that removes them!

For context although this has always been v6 documented behavior, the bans have historically all been manually removed when they rotate out, so that's why this is only rearing its head now. Sorry for the confusion!

Roudique commented 3 years ago

@glacials Thanks, sorry for opening this issue!

Shoulda read the docs!