glacier-modding / H3-Unofficial-Community-Patch

Community bug fixes and stuff for Hitman 3
https://www.nexusmods.com/hitman3/mods/784
Other
3 stars 12 forks source link

feat: change sitting animation on 47's bedroom balcony sunbed to match the sunbed outside #227

Closed dribbleondo closed 4 days ago

dribbleondo commented 2 weeks ago

fixes #226

VoodooHillbilly commented 1 week ago

Did you intend to move these, or did Glacier Kit add more unrelated m_mTransform changes?

dribbleondo commented 1 week ago

Did you intend to move these, or did Glacier Kit add more unrelated m_mTransform changes?

  • 5e5f0e35f3b8f107 Vase_Italy_E_Small_01
  • 7d8c712ada43d797 chair_relaxing_hokaido_b_01

Checking this now; I recall the latter is deliberate, but the former definitely isn't.

EDIT: both are being purged.

dribbleondo commented 1 week ago

Done.

VoodooHillbilly commented 1 week ago

LGTM now.

Ocean-Minnow commented 1 week ago

I'm holding off on merging this until I can clear up the confusion on the issue page. 47 is already laying down in that image, so what does this patch change exactly?

dribbleondo commented 1 week ago

I'm holding off on merging this until I can clear up the confusion on the issue page. 47 is already laying down in that image, so what does this patch change exactly?

In vanilla, he sits like this:

image

This patches change it to 47 laying down, as he does on other sunbeds, including the one outside on the ground floor.

image

Ocean-Minnow commented 1 week ago

Ah, I see. Are you sure this is a bug and not an intentional design choice?

dribbleondo commented 1 week ago

Considering all the other sunbeds in WOA are either ones you lay down on or cannot access, I'd say this is a bizaare choice if it's intentional. This fix keeps it consistent with other sunbeds.

This isn't necessarily a bug, but it's certainly a weird inconsistency.

I'd even go so far as to say that this was probably a placeholder until they linked up the right entity (which they did do on the sunbed downstairs).

VoodooHillbilly commented 5 days ago

Is this animation applying to all the furniture for you too? chair1 chair2

Ocean-Minnow commented 5 days ago

I'd even go so far as to say that this was probably a placeholder until they linked up the right entity

This doesn't make sense to me. You're saying they only placed down half a deck chair (despite their editor bundling such things together), but did bother to put in a different interaction animation (which I really doubt requires less effort, especially given that no other deck chair does this and so they'd have to set up a new interaction for it), and then just left it for long enough that they managed to forget to replace it? How would that happen?

Why put in a placeholder animation at all? Why not simply leave the object non-interactable until it's got the right animation? It just doesn't add up :/

dribbleondo commented 4 days ago

Is this animation applying to all the furniture for you too? chair1 chair2

Oh god, that's not something I noticed. How is that happening?!

I'm gonna close this issue, mostly because there isn't much of a consensus, and I'm starting to think this might be out of scope for the mod.