search

glacier-modding / RPKG-Tool

The RPKG tool allows for easy (un)packing of files from the Glacier Engine RPKG file format! Hitman 3 has the most support.
https://glaciermodding.org/rpkg/
Other
47 stars 9 forks source link

Remove the warnings that aren't true in the brick editor #15

Closed atampy25 closed 3 years ago

atampy25 commented 3 years ago

Through the course of this commit, I embarked on a journey that ended with me learning a lot about C++ programming and me removing the warnings that aren't true in the brick editor. Specifically, the warnings are as follows:

WARNING: When selecting the output folder on the next dialog window...

Do not select the Hitman Runtime folder as the output folder otherwise your Hitman game RPKGs could be overwritten!

in the Generate TEMP Files function, and

WARNING: When selecting the output folder on the next dialog window...

Do not select the Hitman Runtime folder as the output folder otherwise your Hitman game RPKGs could be overwritten!

in the Generate TEMP JSON Files function.

These warnings needed to be removed as they were not true. This betrayal of the user's trust has turned away countless users and left a sour taste in the mouths of anyone who uses the program. Specifically, the warnings are false because while they claim that your Hitman game RPKGs could be overwritten, nothing of the sort can happen in these specific functions - 1. because the generated files are not RPKGs and 2. because the function provides a new folder for the files (for god knows what reason) and therefore could not overwrite the Runtime directory when the Runtime directory is selected in the function.

atampy25 commented 3 years ago

I have just been informed that it is in fact C# that I edited. This heinous mistake will never occur again, and I am truly sorry for any inconvenience or betrayal of trust this may have caused in the audience I am priviliged to hold.

AnthonyFuller commented 3 years ago

LGTM. I for one am so dearly sorry for the inconvience and distress this has caused you.

atampy25 commented 3 years ago

Not sorry enough, gimme $500