Closed AnthonyFuller closed 1 year ago
Does this work fine for resources that have no known paths?
Download the artifacts for this pull request:
Does this work fine for resources that have no known paths?
Yes. It uses the same function as the ASVA JSON function for example.
If it's unknown for meta -> json then it will just be 00XXXXXXXXXXXXXX
.
If it's not 00XXXXXXXXXXXXXX
(or just not a number), for json -> meta, it will hash it.
The ASVA -> JSON function checks to see if [
is in the string to decide if it should hash the string, I feel this isn't really the best option for it as if someone just puts a string in it there e.g. my_new_file
, it won't be hashed. Which of course, isn't best practice from the user, but it's artificially limiting. The ASVA -> JSON function, if the "ASVA" value is not a valid number or contains [
will give a hash value of 0, producing this:
Which is far from ideal, this should be revised.
Hash meta JSON files now check for [
at the start of the hash_value
like dependencies before hashing.
Which is far from ideal, this should be revised.
I honestly think that applies to the entirety of this program.
As title:
Before:
After: