search

glacier-modding / RPKG-Tool

The RPKG tool allows for easy (un)packing of files from the Glacier Engine RPKG file format! Hitman 3 has the most support.
https://glaciermodding.org/rpkg/
Other
47 stars 9 forks source link

Remove timing from some functions #88

Closed RDIL closed 4 months ago

RDIL commented 1 year ago

I know this may be a controversial change, but my reasoning for this is that it just greatly reduces a bunch of logic that just... does not need to be here. Reducing the number of variables and such just makes it more readable, and will help with splitting it all up more.

github-actions[bot] commented 1 year ago

Download the artifacts for this pull request:

Notexe commented 1 year ago

This breaks the search progress for deep search in the GUI image

RDIL commented 1 year ago

@Notexe a lot of the GUI interop breaks because of this... looking for a solution.

Notexe commented 1 year ago

Honestly not a huge fan of this PR, it sacrifices user experience in the GUI (for slight speed increases?). Deep search doesn't have a progress bar anymore so you can't even tell if it's still working or the current progress of it. The new text for importing RPKGs is alright I suppose but still not as nice as before.

It also has broken the ability to load the repository file in the GUI: image

There are probably other functionalities also broken by this PR which I haven't found yet. Sorry, but I don't really see the need for these changes at all.