search

gladevise / remark-link-card

remark-link-card-gladevise.vercel.app
MIT License
27 stars 8 forks source link

fix: use hash value for file name #16

Closed Robot-Inventor closed 8 months ago

Robot-Inventor commented 8 months ago

This pull request changes the filename of the cached images to use a hash value instead of a URL.

The URLs of open graph images on some sites are very long due to parameters. Caching such images may result in an error because the file name is too long.

By using hash values, the length of filenames is kept constant and duplicate images are eliminated.

vercel[bot] commented 8 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @gladevise on Vercel.

@gladevise first needs to authorize it.

gladevise commented 8 months ago

@Robot-Inventor Thank you for your pull request. I appreciate the effort you've put into improving our caching system for open graph images. Your proposed change to use hash values instead of URLs for cached image filenames seems like a sensible approach to address the issue of overly long filenames caused by lengthy URLs with parameters.

I will review your code changes thoroughly and provide feedback or suggestions if needed.

Suree33 commented 6 months ago

I've encountered an issue with a problem with long ogimage filenames in my project, which I believe will be resolved by the changes proposed in this pull request. However, it seems that the deployment is currently blocked on Vercel with an "Authorization required to deploy" error.

Could you please authorize the deployment if everything is ok? It would help me a lot.

Suree33 commented 5 months ago

I've encountered an issue with a problem with long ogimage filenames in my project, which I believe will be resolved by the changes proposed in this pull request. However, it seems that the deployment is currently blocked on Vercel with an "Authorization required to deploy" error.

Could you please authorize the deployment if everything is ok? It would help me a lot.

@gladevise Could you please provide an update on this issue? If there is any additional information or action required from my side, please let me know.

Robot-Inventor commented 5 months ago

Hi @Suree33,

Thank you for your interest in this pull request. Perhaps the maintainer is busy. If necessary, you can install the package via GitHub.

npm install git+https://github.com/gladevise/remark-link-card.git