search

gladkia / igvR

An R Bioconductor package providing interactive connections to igv.js (the Integrative Genomics Viewer) in a web browser
MIT License
42 stars 4 forks source link

unify igvR and igvShiny removeTracksByName signature #23

Closed paul-shannon closed 1 year ago

paul-shannon commented 1 year ago

@vjcitn @stankiewicz565

Vince and Sara,

This may not be an easy fix, since igvR is an S4 object, and igvShiny is only functions.

in igvR/igvR.R:

removeTracksByName(igv, trackNames)             # an S4 method

in igvShiny:

removeTracksByName(session, id, trackNames)  # a simple function
vjcitn commented 1 year ago

Can't the S4 method have a three argument signature and dispatch properly for the two packages? Or you could use "ANY" for the second parameter of the S4 method and then test for classes of function inputs.

vjcitn commented 1 year ago

I can take a shot at this if we are agreed that both packages are in their mature state for now. I would then fork both and try to do the mods.

paul-shannon commented 1 year ago

That would be most welcome, Vince. Thank you!

On Nov 23, 2022, at 11:49 AM, Vince Carey @.***> wrote:

I can take a shot at this if we are agreed that both packages are in their mature state for now. I would then fork both and try to do the mods.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.