gladkia / igvShiny

An htmlwidget version of igv, for RStudio and Shiny apps
https://gladkia.github.io/igvShiny/
Other
36 stars 24 forks source link

Resolve notes #69

Closed karollayna closed 7 months ago

karollayna commented 7 months ago

I was trying to resolve 8notes:

  1. Consider adding the maintainer's ORCID iD in 'Authors@R' - not done
  2. Avoid 1:...; use seq_len() or seq_along() - done
  3. Avoid 'cat' and 'print' outside of 'show' methods - done for 1 of 3
  4. The recommended function length is 50 lines or less. There are 7 functions greater than 50 lines. - not done
  5. Consider adding runnable examples to man pages that document exported objects. - added one example
  6. Consider adding a NEWS file, so your package news will be included in Bioconductor release announcements. - done
  7. Consider shorter lines; 148 lines (5%) are > 80 characters long. - limited
  8. Consider multiples of 4 spaces for line indents; 618 lines (23%) are not. - not done
gladkia commented 7 months ago

I was trying to resolve 8notes:

  1. Consider adding the maintainer's ORCID iD in 'Authors@R' - not done
  2. Avoid 1:...; use seq_len() or seq_along() - done
  3. Avoid 'cat' and 'print' outside of 'show' methods - done for 1 of 3
  4. The recommended function length is 50 lines or less. There are 7 functions greater than 50 lines. - not done
  5. Consider adding runnable examples to man pages that document exported objects. - added one example
  6. Consider adding a NEWS file, so your package news will be included in Bioconductor release announcements. - done
  7. Consider shorter lines; 148 lines (5%) are > 80 characters long. - limited
  8. Consider multiples of 4 spaces for line indents; 618 lines (23%) are not. - not done

@karollayna - 1st, 3rd, 5th and 7th done. Two notes remained (4th and 8th), which is fine.

gladkia commented 7 months ago

GJ!