search

gladly-team / next-firebase-auth

Simple Firebase authentication for all Next.js rendering strategies
https://nfa-example-git-v1x-gladly-team.vercel.app/
MIT License
1.34k stars 290 forks source link

Use modular Firebase admin in v1.x #488

Closed kmjennison closed 2 years ago

kmjennison commented 2 years ago

Is your feature request related to a problem? Please describe.

We should take advantage of modular Firebase admin: https://firebase.google.com/docs/admin/migrate-node-v10#use-modules-instead-of-namespaces

Describe the solution you'd like and how you'd implement it A clear and concise description of what you want to happen.

Currently, we do:

import * as admin from 'firebase-admin'

We should use:

import { initializeApp } from 'firebase-admin/app'

Is this a breaking change? Would this require existing users to change how they're using next-firebase-auth?

[Edited] Yes, firebase-admin would need to be v10+.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

None

louisgv commented 2 years ago

Firebase just released v11: https://github.com/firebase/firebase-admin-node/releases/tag/v11.0.0

I will try to use it. If there's any issue, should I report them here or should I make a new one? @kmjennison

kmjennison commented 2 years ago

@louisgv Please open a separate issue if you have a problem with v11. Thanks!

kmjennison commented 2 years ago

Closed in #548.