gladly-team / next-firebase-auth

Simple Firebase authentication for all Next.js rendering strategies
https://nfa-example-git-v1x-gladly-team.vercel.app/
MIT License
1.34k stars 291 forks source link

Allow installing next-firebase-auth in a Next v13 project #585

Closed bourquep closed 1 year ago

bourquep commented 1 year ago

Is your feature request related to a problem? Please describe.

I have tried to nom install next-firebase-auth in a brand new NextJS v13 project, and it failed due to this peer dependency constraint.

Describe the solution you'd like and how you'd implement it

Although NextJS 13 introduces the new app directory feature, this is opt-in only and there are no breaking changes in the other aspects of NextJS. I believe next-firebase-auth should be usable with NextJS 13 regular pages.

I suggest updating next-firebase-auth's peer dependency to allow NextJS v13.

Is this a breaking change?

No

kmjennison commented 1 year ago

Thanks for the issue!