gladly-team / next-firebase-auth

Simple Firebase authentication for all Next.js rendering strategies
https://nfa-example-git-v1x-gladly-team.vercel.app/
MIT License
1.34k stars 291 forks source link

tenant support to v1.x #647

Closed juhanakristian closed 1 year ago

juhanakristian commented 1 year ago

Continuing the work of @Twister42 and @HegarGarcia

Fixes some issues mentioned in #429 comments

The changes were originally made to main but this PR is made against v1.x branch

vercel[bot] commented 1 year ago

@juhanakristian is attempting to deploy a commit to the Gladly Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 :tada:

Comparison is base (ee6443e) 98.05% compared to head (10ec5cd) 98.10%.

:exclamation: Current head 10ec5cd differs from pull request most recent head e450c8e. Consider uploading reports for the commit e450c8e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1.x #647 +/- ## ========================================== + Coverage 98.05% 98.10% +0.04% ========================================== Files 31 31 Lines 875 895 +20 Branches 257 272 +15 ========================================== + Hits 858 878 +20 Misses 17 17 ``` | [Impacted Files](https://app.codecov.io/gh/gladly-team/next-firebase-auth/pull/647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gladly-team) | Coverage Δ | | |---|---|---| | [src/configTypes.ts](https://app.codecov.io/gh/gladly-team/next-firebase-auth/pull/647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gladly-team#diff-c3JjL2NvbmZpZ1R5cGVzLnRz) | `50.00% <ø> (ø)` | | | [src/createAuthUser.ts](https://app.codecov.io/gh/gladly-team/next-firebase-auth/pull/647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gladly-team#diff-c3JjL2NyZWF0ZUF1dGhVc2VyLnRz) | `100.00% <100.00%> (ø)` | | | [src/firebaseAdmin.ts](https://app.codecov.io/gh/gladly-team/next-firebase-auth/pull/647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gladly-team#diff-c3JjL2ZpcmViYXNlQWRtaW4udHM=) | `91.89% <100.00%> (+0.30%)` | :arrow_up: | | [src/initFirebaseClientSDK.ts](https://app.codecov.io/gh/gladly-team/next-firebase-auth/pull/647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gladly-team#diff-c3JjL2luaXRGaXJlYmFzZUNsaWVudFNESy50cw==) | `100.00% <100.00%> (ø)` | | | [src/testHelpers/authUserInputs.ts](https://app.codecov.io/gh/gladly-team/next-firebase-auth/pull/647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gladly-team#diff-c3JjL3Rlc3RIZWxwZXJzL2F1dGhVc2VySW5wdXRzLnRz) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nfa-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2023 8:06pm
juhanakristian commented 1 year ago

The review issues have been fixed but I'll need to fix the issues from the TypeScript conversion

kmjennison commented 1 year ago

Appreciate it! Sorry for blowing up your PR with all the changes!

juhanakristian commented 1 year ago

The conflicts have been resolved now but it looks like bundle size check is failing in the pipeline. Anything I should do about that?

juhanakristian commented 1 year ago

Thanks for making the last fix and merging the PR 👍

kmjennison commented 1 year ago

Of course! Thank you for your work on this!