search

gladly-team / next-firebase-auth

Simple Firebase authentication for all Next.js rendering strategies
https://nfa-example-git-v1x-gladly-team.vercel.app/
MIT License
1.33k stars 290 forks source link

Let user specify the firebase app name #714

Closed justinmann closed 2 weeks ago

justinmann commented 1 month ago

Safari / Firebase do not like each other: https://github.com/firebase/firebase-js-sdk/issues/7888

To workaround their animosity, we need to change the app name for firebase to something without [].

vercel[bot] commented 1 month ago

@justinmann is attempting to deploy a commit to the Gladly Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nfa-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 10:09pm
MvRemmerden commented 2 weeks ago

@justinmann If you don't plan on moving this forward, I could give it a try, as I think this might also help with the problems we are seeing that are blocking users from upgrading above 9.16.0 (e.g. https://github.com/gladly-team/next-firebase-auth/issues/711 and https://github.com/gladly-team/next-firebase-auth/issues/710).

@kmjennison Do you have any preference how to solve the dependency problem? There are a couple of ways this could be tackled, and I want to make sure it's going the direction you prefer.

MvRemmerden commented 2 weeks ago

I gave it a try in https://github.com/gladly-team/next-firebase-auth/pull/716.

kmjennison commented 2 weeks ago

@MvRemmerden Thanks! Commented on that PR.

kmjennison commented 2 weeks ago

Closed in #716.