search

gladly-team / next-firebase-auth

Simple Firebase authentication for all Next.js rendering strategies
https://nfa-example-git-v1x-gladly-team.vercel.app/
MIT License
1.34k stars 290 forks source link

Let user specify the firebase app name #716

Closed MvRemmerden closed 3 months ago

vercel[bot] commented 3 months ago

@MvRemmerden is attempting to deploy a commit to the Gladly Team on Vercel.

A member of the Team first needs to authorize it.

MvRemmerden commented 3 months ago

@kmjennison I think this PR might be ready, would you mind approving it to be deployed on Vercel so we can see whether any of the checks fail? 🙂

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nfa-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 2:25pm
MvRemmerden commented 3 months ago

@kmjennison I might need some help here. It looks like the problem is due to this change here: https://github.com/gladly-team/next-firebase-auth/pull/716/files#diff-40051885c173eb84152e58b7e9f3cbac7bd1e5d9de2520a1bd2a4253b4a6b9a0R108

I'm not sure if we just need to adapt the test to ensure that the app is initialized before, or if there is a bug here in the actual code.

Would you mind having a look yourself?

MvRemmerden commented 3 months ago

Update: I think I got it working, it might have just been missing mocked configs in the tests, everything is passing now ✅

MvRemmerden commented 3 months ago

@kmjennison Awesome, committed, back to you 🙂