glamod / cdm_reader_mapper

MIT License
1 stars 5 forks source link

expand pre-comit hooks #56

Closed ludwiglierhammer closed 3 months ago

ludwiglierhammer commented 3 months ago

Hi @lizkent, I found a typo in the ICOADS code tables. Can you help me out?

e.g. deck195_II_td11

"-": "observation taken in port ot immediate vicinity",

What should ot be; or, at, anything else?

lizkent commented 3 months ago

Hi,

Should be “or” I think,

Liz

From: Ludwig Lierhammer @.> Date: Tuesday, 25 June 2024 at 14:52 To: glamod/cdm_reader_mapper @.> Cc: Elizabeth Kent @.>, Mention @.> Subject: Re: [glamod/cdm_reader_mapper] expand pre-comit hooks (PR #56)

Caution: This email has originated from outside of the organisation. Do not click links or open attachments unless you have verified the sender and content is safe. Thank you.

Hi @lizkenthttps://github.com/lizkent, I found a typo in the ICOADS code tables. Can you help me out?

e.g. deck195_II_td11https://github.com/glamod/cdm_reader_mapper/blob/main/cdm_reader_mapper/mdf_reader/code_tables/deck195_II_td11/port_ind.json

"-": "observation taken in port ot immediate vicinity",

What should ot be; or, at, anything else?

— Reply to this email directly, view it on GitHubhttps://github.com/glamod/cdm_reader_mapper/pull/56#issuecomment-2189022241, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AELLE7RQYTSC7ER6GRDD6S3ZJFYYDAVCNFSM6AAAAABJZFWE3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBZGAZDEMRUGE. You are receiving this because you were mentioned.Message ID: @.***>

This email and any attachments are intended solely for the use of the named recipients. If you are not the intended recipient you must not use, disclose, copy or distribute this email or any of its attachments and should notify the sender immediately and delete this email from your system. The National Oceanography Centre (NOC) has taken every reasonable precaution to minimise risk of this email or any attachments containing viruses or malware but the recipient should carry out its own virus and malware checks before opening the attachments. NOC does not accept any liability for any losses or damages which the recipient may sustain due to presence of any viruses. Opinions, conclusions or other information in this message and attachments that are not related directly to NOC business are solely those of the author and do not represent the views of NOC.