glamod / glamod-ingest

Database preparation and ingestion for GLAMOD
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Update marine scripts to generate SQL and load PSVs #35

Closed agstephens closed 3 years ago

agstephens commented 3 years ago

The old code was here:

  1. Create SQL files to load DB:

    https://github.com/glamod/glamod-ingest/blob/master/src/populate/create-sqls-marine.sh

...which called...

https://github.com/glamod/glamod-ingest/blob/master/src/populate/create-sql-marine-year.sh

  1. Actually run the SQL files that were created:

    https://github.com/glamod/glamod-ingest/blob/master/src/populate/load-marine-sql.sh

The new code should live in:

https://github.com/glamod/glamod-ingest/tree/master/scripts/marine

Important factors for refactoring:

SteveDonegan commented 3 years ago

I have completed the alterations in my own fork so will submit a merge request so we can discuss and review. Ag - I think you mentioned you needed to do some updates before testing the actual psql input into a db?

agstephens commented 3 years ago

Fixed in Pull Request. Review before closing.

agstephens commented 3 years ago

Working.