glamod / glamod-marine-processing

Code and configuration for marine data processing
MIT License
0 stars 2 forks source link

Marine Quality control #7

Closed ludwiglierhammer closed 3 months ago

ludwiglierhammer commented 3 months ago
  1. Both quality control scritps marine_qc and marine_qc_hires write infos to ID_file.txt. Where do we use this file again?
  2. The file naming convention of metoffice_qc/base data is set in the class Deck property write_qc. For release 7.0 we used the same scritps used in release 6.0. The file naming convention of the release 6.0 metoffice_qc/base differs from that of reelase 7.0. The release file naming convention is set in the class Voyage property write_qc. This class is never called in any scripts. What are the consequenzen for level1e data?
ludwiglierhammer commented 3 months ago

@aanderss: feel free to list your QC issues/questions here.

ludwiglierhammer commented 3 months ago

2 is also a issue to discuss here

ludwiglierhammer commented 3 months ago
  1. level1e script uses the class Deck property write_qc's file naming convention. This question should be solved.
ludwiglierhammer commented 3 months ago

level1e script:

if 'location_quality' == 2:
    'report_quality' == 1

see https://github.com/glamod/cdm_reader_mapper/pull/37

if 'report_time_quality' == 4 or 'report_time_quality' == 5:
    'report_quality' = 1

see https://github.com/glamod/cdm_reader_mapper/issues/36