search

glamod / glamod_landQC

QC for land data
0 stars 0 forks source link

Remove wind direction missing data indicators (999) when "C-Calm" Measurement flag set #74

Closed rjhd2 closed 1 year ago

rjhd2 commented 1 year ago

Update at USAF to fix missing calm period wind speeds (see Dunn et al, 2022) has resulted in "C-Calm" being added to the mesurement flags for wind speed and wind direction in the latest pull from USAF. They have also included "999" in the wind direction observation_value field - as per a standard missing data indicator. However, we don't use this approach in these .psv data, so these need to be removed.

Notes below from Nancy Casey (NCEI): Here's just a sample of old notes I took -- so it's incomplete but still illustrates the issue.

IFF: WMO-22676-wind_direction-220.psv
220|WMO-22676|||2013|05|25|18|00|63.583|45.633|62|360|1-Good|360|degrees|FM12-SYNOP-fixed-land-stn_4-USAF-sfc-hrly|C-Calm|
220|WMO-22676|||2013|05|25|18|00|63.583|45.633|62|999|0-Not-Checked|999|degrees|FM12-SYNOP-fixed-land-stn_4-USAF-sfc-hrly|C-Calm|

Here's a different example of 2 lines in ISD format:

22820_WMO 2013051003 999 0 C0000 4 ... REMSYN08822820 21/05 90000 10045 20043 39975 40112 57004 76164 333 20039 55056 60152 96045 91110=
22820_WMO 2013051003 360 1 C0000 1 ... REMSYN004BUFR
rjhd2 commented 1 year ago

Code updated, but currently fix=True so missing calm values should be being replaced. Need to check in output files to ensure they are handling that correctly

rjhd2 commented 1 year ago

Need to check whether this output is implementing the fix or not correctly before raising a PR

rjhd2 commented 1 year ago

Noting that the fix option for the wind direction is applied to the data variable within the station object, but this is not transferred across to the data frame. The plan was to not make any data changes as part of this QC, so this was never implemented.