search

glample / fastBPE

Fast BPE
MIT License
656 stars 96 forks source link

setup fails when Cython is not available #26

Open ink1 opened 5 years ago

ink1 commented 5 years ago

Hi, in your setup, you are trying to handle a case when Cython is not available but it does not work so you should either put Cython as a dependency and throw an error or provide the missing file. https://github.com/glample/fastBPE/blob/1fd33189c126dae356b9e187d93d93302fa45cef/setup.py#L6 If Cython is missing then

extension = 'cpp'

which leads to "fastBPE/fastBPE." + extension but there is no fastBPE/fastBPE.cpp file.

myleott commented 5 years ago

Ah, this file is provided in the package on pypi, but not distributed in the source on github. Can you install Cython and build that way?

ink1 commented 5 years ago

Hi, yes, that exactly what i had done.