glanceapp / glance

A self-hosted dashboard that puts all your feeds in one place
GNU Affero General Public License v3.0
8.56k stars 297 forks source link

[Bug] Bookmark columns are mis-aligned with group title #217

Closed cody-at-ats closed 2 months ago

cody-at-ats commented 2 months ago

Hi, thank you for creating an awesome dashboard.

Everything is working great, but I noticed a minor issue when a bookmark list gets a bit long, then the title of the group is offset from the list like in this screenshot:

image

I'm not sure if this was changed or existed in a previously release. Happy to try some things out or maybe customize some css if needed.

Note: the issue does not occur if the screen width is small enough that the bookmarks are displayed in a single column.

svilenmarkov commented 2 months ago

Hey, thanks for reporting this!

I could not replicate the issue, could you please double check if you've accidentally defined 4 groups rather than 3 where the first group has only a title and no links in it? If that's not the case, could you post just the bookmarks widget configuration you used? You can of course redact links/titles/icons.

Side note: while trying to replicate this I did find a different bug where the icons of the links were unintentionally shrinking, I'll get that fixed with the next release.

cody-at-ats commented 2 months ago

Sure! I don't believe there's 4 groups with only a title but my eyes may be deceiving me :/

That's good news that this led you to fix another bug :)

Here is the bookmarks widget config I have with everything redacted (it's yml but GH only allows .txt :( )

bookmarks.txt

svilenmarkov commented 2 months ago

It does look like that's what happened, YAML is the devil sometimes. 😅

Notice the extra - in front of links:

  - type: bookmarks
    groups:
      - title: Redacted Title Here
--    - links:
++      links:
          - title: Redacted Title Here
            url: https://redacted.com
            icon: redacted-logo.png
            same-tab: true
cody-at-ats commented 2 months ago

Wow. Thank you. Must be tired today :(. Definitely no issue here other than my 👀.