search

glandfried / TrueSkillThroughTime.py

The TrueSkill Through Time Python Package
https://trueskillthroughtime.readthedocs.io/en/latest/
Other
34 stars 6 forks source link

Implementation of method for adding new events incrementally. #10

Open apiss2 opened 4 months ago

apiss2 commented 4 months ago

I have separated the addition process of competitions into the add_history method. This modification allows for incremental addition of competitions.

The existing interface remains unchanged.

To prevent inappropriate updating of last_time in agents, each newly added competition is compared with the min(times) of all previously added competitions. This check ensures that every newly added competition occurs after all competitions added prior to it.

Do we need to create new tests for this feature?

Thank you for your review!

glandfried commented 4 months ago

Hi, I add a basic test to your branch for the proposed add_history method. You are relying on the trueskill method, that only serves at the first time. I recommend no touching it. Instead, there is an old unfinished method to add new events, called add_events. Maybe you can finish it. Below the new test you will see a commented test for add_events.