search

glandium / git-cinnabar

git remote helper to interact with mercurial repositories
GNU General Public License v2.0
292 stars 61 forks source link

`git cinnabar --version` `0.7.0-beta.1` wants to update to `0.7.0-beta1` #330

Closed mxinden closed 1 month ago

mxinden commented 2 months ago

I assume there is a typo either in the release name, or in the upgrade logic. Note the difference in the . character:

➜  mozilla-unified git:(bookmarks/central) git cinnabar --version
git-cinnabar 0.7.0-beta.1-d79779e30d88d91816d487016a43b5cbb6ee3e74
WARNING New git-cinnabar version available: 0.7.0-beta1 (current version: 0.7.0-beta.1)
WARNING You may run `git cinnabar self-update` to update.
glandium commented 2 months ago

I was wondering when someone would finally notice. I could fix it for 0.7.0-beta.1 by renaming the tag, but I don't like what the tag would look like so I'm not doing it. I wish the tag could just be the version, but older versions strip the - away and would fail the upgrade if it was... I don't know what went through my head when I did that. Anyways, this will be fixed in next release. I'm writing extensive tests to avoid this problem in the future.

mxinden commented 2 months ago

I should have stated in my initial comment that this is not a big deal for me. My intention behind opening this issue was rather that you might find it helpful.

Anyways, thank you for the response and git-cinnabar in general. Makes my day-to-day life a lot easier @glandium!

glandium commented 1 month ago

Fixed in fcd7c40af