glarimy / glarimy-quiz-app

The source code and resources for Glarimy Quiz community project
0 stars 0 forks source link

Fix the backend #39

Open glarimy opened 6 years ago

glarimy commented 6 years ago

Study the reported defects in the issues #35, #36, #37, #38.

Solution to these defects include changes in the backend (com.glarimy.quiz.model and com.glarimy.quiz.service packages) and frontend (com.glarimy.quiz.app and several xml files).

Your job is to fix the issues only in the back-end.

Here is the process:

  1. Remove the current project from your Android Studio
  2. Create a new project and check-out code from the branch: https://github.com/glarimy/glarimy-quiz-app/tree/test.
  3. Build the project.
  4. Make changes to the code in the package com.glarimy.quiz.service in order to solve the defects reported in the issues #35, #36, #37, #38, wherever applicable.
  5. Make sure that the builds are not failing while you change the code. Also, you are not allowed to change the signatures of the public properties and public methods.
  6. Once you are confident that the code changes are done and build is working fine, check-in the code to the branch https://github.com/glarimy/glarimy-quiz-app/tree/test.

Complete this activity by CoB 19th May 2018.

venumittapalli576 commented 6 years ago

sir i fixed all issues only single issue let score is not updating working on it

glarimy commented 6 years ago

May be you are creating the instance of SimpleScoringService every time. Try making the properties of SimpleScoringService (numberOfAttempts, numberOfPoints) static, though it is not very correct.

But make sure, you run all the test cases #35, #36, #37, #38 before checking in the code.

venumittapalli576 commented 6 years ago

k sir i will try it sir

venumittapalli576 commented 6 years ago

completed fixing of backed issues and checked in the code

glarimy commented 6 years ago

Great! Enjoy the weekend. Will assign the last set of tasks on Monday :-)

glarimy commented 6 years ago

Can you confirm that the code was checked-in to the branch https://github.com/glarimy/glarimy-quiz-app/tree/test?

Changes committed to master branch of https://github.com/glarimy/glarimy-quiz-app are no longer picked up for build.

venumittapalli576 commented 6 years ago

sir committed code in new link provided