glasgow-ipl / ietfdata

Python libraries to access the IETF DataTracker and RFC Index
BSD 2-Clause "Simplified" License
18 stars 13 forks source link

Allow empty event type when fetching document events #113

Closed georgefourm closed 3 years ago

georgefourm commented 3 years ago

Hello! While using the library, I encountered an error when trying to retrieve all document events without specifying an event type. I assume this was not intended, as the parameter is specified as optional, however, when left as is, the assertion in _retrieve_multi when iterating over the parameters fails. I added a check similar to the other parameters, and a relevant test. Please let me know if there is anything I should change. Thank you!

lumisota commented 3 years ago

Good spot; thanks!