Mailarchive::threads() implementation

glasgow-ipl / ietfdata

Python libraries to access the IETF DataTracker and RFC Index

BSD 2-Clause "Simplified" License

18 stars 13 forks source link

Mailarchive::threads() implementation #136

Closed lumisota closed 9 months ago

lumisota commented 10 months ago

This follows on from the discussion in #133. This implementation returns envelopes where:

there are no parents returned by in_reply_to; or
none of the parents returned by in_reply_to are messages within the same mailing list.

csperkins commented 10 months ago

Message https://mailarchive.ietf.org/arch/msg/ietf-announce/96y6OVChtga3jzPs9YdEsS5g6Yc/ was sent to ietf-announce, but has many replies on admin-discuss. If we search for threads on admin-discuss and limit the search to that list, we'll find two threads each starting from a direct reply to this. If we don't limit the search to the list, we'll find one thread starting from the original message on ietf-announce.

Which do we want?

lumisota commented 10 months ago

I think I'd lean towards giving results limited to threads that don't have parents within the same list (so in this example, returning the two threads separately).

There should perhaps be another threads() method further up (maybe on MailArchive?) that finds threads across multiple lists?

csperkins commented 9 months ago

Commit 3e602bb addresses this in a different way. Does it make sense? @lumisota @mladenk42