search

glasgowcompbio / vimms

A programmable and modular LC/MS simulator in Python
MIT License
19 stars 6 forks source link

Add option for Optimal Controller to run as part of Sequence Manager #124

Closed vinnydavies closed 2 years ago

vinnydavies commented 4 years ago

Currently optimal controller needs to be ran as a loop of the same controller. It should be straight forward to make this into a variation of sequence manager

joewandy commented 4 years ago

Would be nice if this can also go into the sequence manager? https://github.com/sdrogers/vimms-fusion/blob/master/analysis/experiment_2020_09/02_Top%20N%20with%20Persistent%20Exclusion%20List.ipynb

sdrogers commented 4 years ago

Let's think about this -- it's a general problem that somehow the state of the controller needs to be passed onto the next controller

joewandy commented 4 years ago

Yeah it was already discussed before too in https://github.com/sdrogers/vimms/issues/39 (see last comment there).

vinnydavies commented 4 years ago

easy enough to just update schedule between each sample, but I guess thats a quick fix. For the more advanced fix we'd need to remember that we wouldnt necessarily want to pass things on each time