Iss 52

[joewandy]

As discussed in issue #52, we want controllers to be able to specify what are the initial scan parameters to send.

Made the following changes to Environment:

• Modified the simulated Environment to send the initial scan when the acquisition start event is triggered, instead of having it inside the run() method. This is for consistency with the IAPI environment.
• Added the method get_initial_scan_params in the base Controller class. By default this specifies the default MS1 scan parameters. The Environment will then call this method to pick up the initial scan parameter to send when acquisition starts.
• Sub-controllers can override this get_initial_scan_params if they wish to send different kind of initial scan. For e.g. inFixedScansController, this would simply be the first scan in the fixed schedule.
• Made the corresponding change on the IAPI side: https://github.com/sdrogers/vimms-fusion/commit/8ad2f53449672d5ac4633a36e1ed5dbcd649f140. Completely untested, but it should work i hope ...

Made two controller changes along the way too:

• Simplified AIF controller to accept a ms1_source_cid_energy parameter in the constructor, which is used to specify the source CID energy for the AIF scans.
• Simplified FixedScansController to only use a list of scan parameters (previously it could also be a dataframe). Neater this way.

[sdrogers]

I don't understand why you've changed the fixed scans controller like that? I agree it's neater to provide a list of scans, but changing that means that @vinnydavies tests will all be broken (that's the error you're seeing). If we want to change to that behaviour, I think it should be a separate issue and one that we check with @vinnydavies.

My vote would be to change it back.