Closed joewandy closed 4 years ago
I don't understand why you've changed the fixed scans controller like that? I agree it's neater to provide a list of scans, but changing that means that @vinnydavies tests will all be broken (that's the error you're seeing). If we want to change to that behaviour, I think it should be a separate issue and one that we check with @vinnydavies.
My vote would be to change it back.
As discussed in issue #52, we want controllers to be able to specify what are the initial scan parameters to send.
Made the following changes to Environment:
get_initial_scan_params
in the base Controller class. By default this specifies the default MS1 scan parameters. The Environment will then call this method to pick up the initial scan parameter to send when acquisition starts.get_initial_scan_params
if they wish to send different kind of initial scan. For e.g. inFixedScansController
, this would simply be the first scan in the fixed schedule.Made two controller changes along the way too:
AIF
controller to accept ams1_source_cid_energy
parameter in the constructor, which is used to specify the source CID energy for the AIF scans.