Closed sdrogers closed 3 years ago
Currently fixed by setting the CURRENT_TOP_N attribute in ScanParameters for all scans to 10.
I wonder whether a more sustainable long-term solution is making it more common to pass a scan time dictionary to the MS object. It can currently handle this: https://github.com/sdrogers/vimms/blob/c5c0d77e4a4f587588d77b29c61d23511f8d39c8/vimms/MassSpec.py#L437-L438 The dictionary could, presumably hold a method that could generate random times or constants?
From meeting 24th July - this method for setting times should be the default so that it doesn't rely on the peak_sampler
Action required:
A default dictionary should be provided (as a constant in ViMMS.Common
) with standard params (1: 0.4, 2:0.2).
scan_timing
dictionary (see MassSpec.py). Make that the default. peak_sampler
object in DataGenerator.pyDone
Current scan time sampling code requires a value of
N
in order to sample. This is because of the dependence of time onN
. In DIA controllers, there is noN
and it seems to default to zero somewhere which then results in no time being sampled at: https://github.com/sdrogers/vimms/blob/b8b78c64389a8c2afe903f4e3bd2fe818b408720/vimms/MassSpec.py#L457Options: