glasgowcompbio / vimms

A programmable and modular LC/MS simulator in Python
MIT License
19 stars 6 forks source link

ROI controller codes #220

Closed joewandy closed 3 years ago

joewandy commented 3 years ago

The ROI/Grid Controller codes seem a bit messy.

  1. Extract ROI generation into its own class, so we can swap between normal or SmartROI
  2. Extract scoring into its own class
  3. Can also pass in different time exclusion method (e.g. DEW, WeightedDEW) to the scoring calculation
  4. Write unit tests to make sure everything still works the same