search

glasgowcompbio / vimms

A programmable and modular LC/MS simulator in Python
MIT License
19 stars 6 forks source link

Duplicate ROI creation codes #232

Closed joewandy closed 2 years ago

joewandy commented 2 years ago

@mcbrider5002 noticed these duplicate codes in make_roi, which is used when extracting ROIs from an mzML file to create chemical objects, and RoiBuilder for real time ROI creations in controllers. We should tidy them up.

https://github.com/glasgowcompbio/vimms/blob/ea457a5d1227837b4782861652f32d6b3bfe1e80/vimms/Roi.py#L369-L387

https://github.com/glasgowcompbio/vimms/blob/master/vimms/Controller/roi.py#L67-L91