search

glasgowcompbio / vimms

A programmable and modular LC/MS simulator in Python
MIT License
19 stars 6 forks source link

SmartROI initial scan issue #25

Closed sdrogers closed 4 years ago

sdrogers commented 4 years ago

branch: shifted_controllers and roi_debug SmartROI was hanging after receiving an initial scan from the machine. This was not the scan that we had sent from the bridge. Seems to be a problem in update_roi, which is called regardless of whether or not the scan is one we want to process. Fixed in roi_debug by moving this line inside the check as to whether this is a scan we want to process. But: need to check why this was happening -- why update_roi was upset with an MS1 scan from the machine. Suggested test: in shifted_controllers branch -- wrap the update_roi method in a try block and send the exception to the log...

sdrogers commented 4 years ago

We think this is due to the ROI code not handling profile mode scans. Needs to be checked, but no longer a priority.