search

glasgowcompbio / vimms

A programmable and modular LC/MS simulator in Python
MIT License
19 stars 6 forks source link

Unit test works locally but not on github action #254

Closed joewandy closed 1 year ago

joewandy commented 1 year ago

When running on github action, the test tests/test_controllers_TopN.py::TestTopNController::test_TopN_controller_with_simulated_chems keeps failing, e.g. https://github.com/glasgowcompbio/vimms/actions/runs/4053520902/jobs/6974230650.

However all tests run successfully on my computer.

image

Maybe some randomness in the input data generation?

joewandy commented 1 year ago

Not sure what causes this .. but now fixed after specifying Python 3.10 in the Pipfile / conda yml.

https://github.com/glasgowcompbio/vimms/commit/75574f112e987f568c7a5279c9e11264360a5cf9