search

glasgowcompbio / vimms

A programmable and modular LC/MS simulator in Python
MIT License
19 stars 6 forks source link

Is it possible to also support Waters WRENS API? #28

Closed joewandy closed 4 years ago

joewandy commented 4 years ago

Look into this more

https://www.google.com/search?q=Waters+Research+Enabled+Software+suite+(WREnS)&oq=wat&aqs=chrome.0.69i59l2j69i60j69i57j69i61j69i60j0.1145j0j7&sourceid=chrome&ie=UTF-8

sdrogers commented 4 years ago

@everyone: is this something we want to devote time / effort to? If "yes", we could contact Corey and see if he was interested in trying some things.

sdrogers commented 4 years ago

or contact Waters direct

joewandy commented 4 years ago

Found this project that interfaces with WREnS: https://origami-ms.lukasz-migas.com/ as an example. Here's how they do it:

  1. Write a C# script that accepts some command-line parameters from users. It would use the WREnS API to connect to MassLynx and control the mass spec. Example.
  2. Compile 1 to get a command-line program. Example.
  3. From Python, we can create a subprocess that calls the result of 2. Example.

For ViMMS, we could add another bridge class e.g. WrensBridge.cs and a mass spec class e.g. WrensMassSpec.py. Hopefully everything else should work fine once we swap out the mass spec? But I'm not sure if it would allow us to handle incoming scans interactively like IAPI? Would need to check the documentation for that, or ask Waters.

Not sure if we want to dedicate much time to this? What do you think? @sdrogers @RonanDaly

RonanDaly commented 4 years ago

Not sure if this is the wisest use of time, given that we don't have a Waters to test on arbitrarily. I would want us to have guaranteed access, otherwise there might be a whole lot of effort for nothing.

joewandy commented 4 years ago

👍 Let's close this issue.