search

glasgowcompbio / vimms

A programmable and modular LC/MS simulator in Python
MIT License
19 stars 6 forks source link

Hardcoded default path to MZmine2 #54

Closed joewandy closed 4 years ago

joewandy commented 4 years ago

See https://github.com/sdrogers/vimms/blob/master/vimms/SequenceManager.py#L32

MZMINE_COMMAND = 'C:\\Users\\joewa\\Work\\git\\MZmine-2.40.1\\startMZmine_Windows.bat'

Since it's required for certain classes, e.g. SequenceManager to run, maybe we should tell user to place that MZmine2 folder inside the vimms folder (also add it to gitignore). This way, the path can be relative to our project.

joewandy commented 4 years ago

Let's just get rid of the default