Controller has too many parameters in the constructor

[joewandy]

When creating say the TopN or the SmartROI controllers, there are too many parameters that can be passed in. This makes the codes messy -- especially when we create a new controller that extends from an existing one, and need to pass all those parameters to the super constructor.

Example: https://github.com/sdrogers/vimms/blob/master/vimms/Controller/roi.py#L253-L269.

Should wrap all those common parameters into its own class.

[sdrogers]

Does it need a whole class? What about just a dictionary?

[sdrogers]

and would it be one class to hold options for all controllers? Or subclass for each controller?

[joewandy]

I'm thinking just one class for the common parameters shared by all controllers, e.g. (AGC, maxit, etc). The others remain as they are, ie. passed as arguments in the constructor.