glasklart / hd

The Retina Glasklart Theme
180 stars 83 forks source link

iPhone 6+ #4735

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hey guys any news on using the icons on a 6 plus?

dreamnet commented 9 years ago

The 6+ needs icons in a higher resolution (180x180px). The icons must also be renamed to ...@3x.png. I think about it when the current bugs in Winterboard and IconBundles are solved, but can't make any promises.

dreamnet commented 9 years ago

OK, I made a icon template for the 6+. Check it out and @jfelchner please try it out and let me know how it looks. The icon is 180x180px and the drawable area is 120x120px. Here are the sample icons from the template: Safari sample with backgroundSafari sample without background Winterboard sample with backgroundWinterboard sample without background Twitter sample with backgroundTwitter sample without background

jfelchner commented 9 years ago

@dreamnet remember back when we did the iPad icon sizes and were debating going vector? Wish we'd done it. There've been like 3 different icon sizes since then. Would've made this a lot easier :smile:

dreamnet commented 9 years ago

@jfelchner Yes, I have collected icon sources since then, currently I have about 2500 source files. About 89MB. Weird hobby eh? :laughing: If I could only find a way to convert them into Glasklart files per script.... As a first step I can write a script that converts the icon sources to 78px(iPhone retina), 100px(iPad retina) and 120px (iPhone6+).

jmaeshawn commented 9 years ago

I use the icons as they are now on my iPhone 6 Plus (@2x). Or are you talking about if you chose to use the "zoomed view" on first startup? It seems like if you choose "standard view" on that page, the icons work fine, like they always have.

jfelchner commented 9 years ago

@dreamnet I'm currently under the weather, but I don't see why I couldn't make a Photoshop script to do that automatically. :)

dreamnet commented 9 years ago

@jmaeshawn Yes, we talk about the "zoomed view". I don't have a 6 plus, so can you tell me what happens if you use the Glasklart theme in the normal view and then switch to zoomed view? @jfelchner If you can do that, it would be very nice. We have the 180x180px template and we have 2500 transparent png source files with 120x120px. The source files needs to be centered in the template and the Glasklart style must be applied.

jmaeshawn commented 9 years ago

It appears as though if you apply Glasklart in normal mode, then change it to zoomed mode, it just zooms in on the icons, scaling them up and making them slightly bigger. They are all still themed, though, and I wouldn't know that they were scaled up at all. :)

I made a animated gif to show you what happens to the icons when changed to zoomed view.

dreamnet commented 9 years ago

@jmaeshawn Thank you very much! How did you get the white circled badge in the screenshot? @jfelchner Hope you are feeling well! I still don't know it it makes sense to add the @3x icons to the theme, this will blow it up to ~ 100MB...

jmaeshawn commented 9 years ago

@dreamnet The white circle badge is my mod of someone's glasklart-style Winterboard badge theme I found and was using on iOS 6 back when the theme was hosted on macthemes.net.

For iOS 7, I couldn't use it anymore due to the way Apple changed the way badges work.

But I recently found that installing the ClassicBadges tweak (and some filename changing) lets you use pre-iOS 7 Winterboard badge themes on iOS 7 and 8, so I was able to revive it :)

Once I get back to my PC, I can post the badge theme that's already been modded to work on iOS 8 here, if you'd like.

dreamnet commented 9 years ago

@jmaeshawn Yes, that would be great! :+1:

TheRyanKing commented 9 years ago

Okay, so I have taken all of the Glasklart Files & made them all 180x180px as well as file named with @3x. If you would like access to these files just message me on Twitter @bitemyapplez . I have also got the Clock correctly sized and working, the calendar resized for the @3x resolution. @dreamnet I know you were asking about the white circle badges. I have also gone ahead and have those bundled up as well.

dreamnet commented 9 years ago

@TheRyanKing Looks and sounds great! I'm not on Twitter, so can you please send me a mail? My mailaddress is in my Github profile. THX!

jmaeshawn commented 9 years ago

@dreamnet The white circles in that bundle look rather pixelated in the screenshot, and don't use the same layer style from the icons...

But are you happy with those, or did you still want these ones I have? http://goo.gl/LNztFM

dreamnet commented 9 years ago

@jmaeshawn The main thing is I want to see how theses badges are made. I will check the link you provided, see how it looks and if I'm happy with it I will integrate them into the theme. I'm at work right now, so give me a view hours.

dreamnet commented 9 years ago

@jmaeshawn The badges are looking good, I have done only slightly modifications and I have added them to the theme. Can you please check if the files I have submitted are OK, because the badges are working only on iOS8 and I have only iOS7 here, so I can't test it. Just one question: SBBadgeBG.png and SBBadgeBG@2x.png have the same size (58x58px), is this correct?

dreamnet commented 9 years ago

@TheRyanKing Thank's for your mail and for the icons - it seems to me you have simply upsized the standard 120x120px Glasklart icons to 180x180px, so... compare (Compass example): ....... simply upsized icon ............... new made icon ........ com apple compass 3x See the difference? Because iOS8 on 6+ does automatic upsizing if no @3x icon is available (as @jmaeshawn wrote above), it makes no sense to me to add simply upsized icons to the theme, they have to be completly remade. I have already done 307 180x180px Glasklart icons so far and have sources for another 2226 icons, but I am already not sure if it makes sense to add them to the theme only for the 6+, because it will blow the theme up to over 100MB. For the beginning, I will add all the @3x icons for the Apple native apps.

jmaeshawn commented 9 years ago

Wow, I'm glad you liked the badges :) I'll test them later and let you know. I have a feeling that they -should- work on both iOS 7 and 8, but haven't actually tried them on 7, so I'll also check them on my iPhone 4S that is still on that version. Did you install ClassicBadges? Because the theme won't work without it.

And I'm pretty sure the SBBadgeBG.png should be half the size of the @2x image, but since I originally was using the badge theme only for myself and all my devices use @2x icons, I never bothered to make a smaller icon... >_<

dreamnet commented 9 years ago

@jmaeshawn Thanks for the tip with ClassicBadges, with this the badges are working on iOS7. The bad thing about this is, that the user must manually add Coolstar's Repo to the cydia sources and install ClassicBadges and the ThemeLib. I have to add this to the description for the next release. The file SBBadgeBG.png is not needed, because Glasklart is only for retina display. With this it is also possible to use the black, blue and red badges from the old iOS6 times! :smiley: sbbadgebg 2xsbbadgebg 2xsbbadgebg 2x I really think I should add this too.... :grey_question:

dreamnet commented 9 years ago

The badges from the old times are back in the master. If ClassicBadges is installed, the user of Glasklart will have the freedom to select from black, blue, read and a transparent badge. :wink:

dreamnet commented 9 years ago

I also removed com.apple.mobiletimer@2x.png from IconBundles and added the clock for ThemeLib to the Glasklart Icons.theme. Have some problems with the second hand, it always comes out ... some kind of brown or pink.... maybe this is a problem only on iOS7.... unbenannt-1 Can someone please download the master and try it out?

jmaeshawn commented 9 years ago

@dreamnet

ClassicBadges is actually on the bigboss repo and could probably be added to the theme as a dependency if you want...

I don't think themelib is on bigboss, but it's not necessary for ClassicBadges to work :)

dreamnet commented 9 years ago

@jmaeshawn Yes, but we need ThemeLib for themeing the clock....

TheRyanKing commented 9 years ago

If I'm not mistaken, ThemeLib is the only one needed. ClassicBadges, ClassicDock, etc. are all replaced by ThemeLib. That was the actual intention of it to begin with (@coolstar).Sent using CloudMagicOn Thu, Dec 4, 2014 at 2:22 PM, glasklart/hd reply@reply.github.com wrote: @jmaeshawn Yes, but we need ThemeLib for themeing the clock....

—Reply to this email directly or view it on GitHub.

dreamnet commented 9 years ago

@TheRyanKing I think you are right - when ThemeLib is installed, the Badges are getting themed on my device without installing ClassicBadges.

TheRyanKing commented 9 years ago

Indeed, well, then the only dependency needed is ThemeLib then...You're welcome (: ... Sent using CloudMagicOn Thu, Dec 4, 2014 at 3:28 PM, glasklart/hd reply@reply.github.com wrote: @TheRyanKing I think you are right - when ThemeLib is installed, the Badges are getting themed on my device without installing ClassicBadges.

—Reply to this email directly or view it on GitHub.

jmaeshawn commented 9 years ago

@dreamnet Okay, I did a little more research and discovered an issue with using ClassicBadges or Themelib... When you mentioned having to get ClassicBadges and themelib from a separate repo, I added it and checked it, and found out that the version of ClassicBadges on that repo was much newer than the one I had been using. I downloaded and installed it, which came bundled with themelib. However, it seems that they broke something with the updates in regards to iPhone 6 plus support. The new ClassicBadges, as well themelib on its own, incorrectly scales the badges on the 6 plus, scaling up 1x images to 2x and making them pixelated, or scaling up 2x images to double size and making them too big.

The old standalone ClassicBadges 1.0-1 that used to be on the bigboss repo and has apparently since been pulled, didn't have this problem, so someone will need to have @coolstar fix this before it themelib can be used reliably... >_<

Rhokk commented 9 years ago

@dreamnet will continue our troubleshooting here.

dreamnet commented 9 years ago

@Rhokk Jup!

Rhokk commented 9 years ago

@dreamnet Let me know if there is a way for the iPhone to get this file without making it 0x0 - blank. Else I'll have to wait till I get back to my PC.

dreamnet commented 9 years ago

@Rhokk That's OK, all AppIconMask.....-files MUST be 0x0px. These are just "dummy"-files, because Glasklart dosen't need to mask the icons.

Rhokk commented 9 years ago

@dreamnet Ok so 0x0 for the mask is all good but I'm getting the same for all the files I try to download to my phone. I was able to use @MagnaMikes files because he zipped them. Just saving the image the normal way makes it go to the camera roll. I have safari downloader plus which lets me save to the actual directory structure however it seems like it has an issue with transparencies?

dreamnet commented 9 years ago

@Rhokk OK, you can download a zip, containing the actual files form the master here. Please remove all files from com.apple.springboard and com.apple.mobileicons.framework bevore copying the ones in the zip to this folders.

Rhokk commented 9 years ago

@dreamnet Awesome thanks for the zip! After extracting, those x3 files are correct instead of being messed up. Anyways, I emptied those two folders before moving the unzipped files over. Changed to 100% icon size and swapped to a brighter wallpaper to make it easier to see. After respringing...


https://cloud.githubusercontent.com/assets/10787286/5992439/97137e12-a9f8-11e4-87f3-e1496a5620ab.jpg

MagnaMike commented 9 years ago

Hmmm... @dreamnet I think the clock icon might be the right size and everything else is too large.

Rhokk commented 9 years ago

Ya it almost seems like the clock is very clear and the other themed icons are a tiny bit rough. Just messing around I enlarged the springboard icons to 130%...


https://cloud.githubusercontent.com/assets/10787286/5992579/50a98d18-a9fd-11e4-9064-49ffc560e407.jpg

MagnaMike commented 9 years ago

The clock icon itself is 172 by 172 pixels, which I think is the dimensions @dreamnet made them to (180px canvas with 4px padding around icon). The other icons are 180 pixels even though I think they were made with the same 4px padding. It seems as if the icons are scaled up to fill the 180px area, while the clock icon, since it is a unique case, is not scaled.

@Rhokk They are a tad rougher. Also, if you didn't know, keep in mind that iFile and iCleaner Pro are not 6+ icons, but they are small icons scaled up to 6+ size so they will always be rougher.

@dreamnet Why don't we just release two themes, one for normal sized icons and one for iPhone 6+? I know it will have less icons because we don't have all the sources, but it will be better than the current situation.

MagnaMike commented 9 years ago

Whoops! I wish there was a confirmation button asking if you were sure you want to close the issue...

dreamnet commented 9 years ago

@MagnaMike Yes, sadly that's true. This is a bug caused by themelib. All icons themed with the IconBundles method are displayed 4px too big. There is no change if you uninstall IconBundles, so it's definetly caused by themelib. I have reported this to @coolstar here and he told me he will check it, but I got no answer from him so far. So we have to wait if he could solve the problem with the new Anemone app or with an update to themelib. Or we can size down all 6500 icons in the IconBundles folder..... :laughing: @Rhokk Thank's again for the screenshot! You have helped us a lot - I will give you extra thanks in the next release. I don't think we can do much more at the moment.

Rhokk commented 9 years ago

@dreamnet It's all good. I'm just happy the clock's black square got solved!

MagnaMike commented 9 years ago

Well for now at least we could scale up the clock icon by the 4px if we wanted to, even though it is not ideal it will match the others.

dreamnet commented 9 years ago

@MagnaMike Releasing different themes for iPhone6 and iPhone6+ is not a good idea I think. As fas as I know, the 6+ uses the normal 120x120px icons - it uses the 180x180px icons only if the user activates the zoom funtion of the 6+. So in my oppinion it would be better to provide an extra icon pack for the 6+ as I did on my website. Scaling up the clock icon could only be a temporary solution (if we do this, we also hve to scale up the Newsstand icons) witch I don't really like. Many users dosent recognize the 4px difference on retina display. I think it's better to leve it as it is at the moment.

MagnaMike commented 9 years ago

@dreamnet Ah, you're right - I read into it. I thought they were always 180px because I didn't know about the zoom feature. :+1:

zmathiasz commented 9 years ago

@dreamnet @MagnaMike First time joining in. :). I am using glasklart on a 6+ and have noticed that regardless of standard or zoom view it will use the 3x icons if they are available. I also see a slight difference on transparency between the two.

2x theme only on standard view

3x theme only on standard view

dreamnet commented 9 years ago

@zmathiasz Welcome and yes, thats right. This is because I had to reproduce the Glasklart baseplate from scratch for the @3x icons without having the original Photoshop file from @maxrudberg. I tried to get as close as possibe to the original, but there is already a little difference. It's hard, but I will try to overwork it in the next days.

jfelchner commented 9 years ago

@dreamnet did you contact @maxrudberg about it? I know he's busy but I'm sure he'd give it to you.

dreamnet commented 9 years ago

@jfelchner Actually not. Currently checking the file sources\Baseplate\Glasklart Baseplate.psd in our Dropbox. Maybe that's the right one... Try to reproduce it... here is the result: Original @2x ......... Copy @3x... 01_glasklart_icon_template_ 2x03_glasklart_icon_template_ 3x Na, that's not really it. It dosent look bad, but we need to match the @2x icon. Can you ask @maxrudberg for help? I'm sure he is listening more to you than to me. My last templates are here.

jfelchner commented 9 years ago

@dreamnet I think that is it actually. All he ever had was the the 2x versions. That was the last one he made. :(

dreamnet commented 9 years ago

I gave the baseplate another try and endet up with this: The left one is the original Glasklart baseplate, just scaled up to @3x size(180x180px) for better comparsion. The right one is the rebuild baseplate in original @3x size. It's also not 100% exact, but it's better than the one I first made. Any thoughts?

MagnaMike commented 9 years ago

@dreamnet That looks really good to me! :+1: :+1: