search

glass-dev / cosmology

Python package for cosmology
https://cosmology.readthedocs.org
MIT License
8 stars 0 forks source link

rename density parameters in LCDM class #1

Closed ntessore closed 1 year ago

ntessore commented 1 year ago

I am not a big fan of the density parameters Om, Omz etc. in the LCDM class.

Can we change those to omega_m0, omega_k0 etc. for redshift 0, and omega_m(z), omega_k(z) for the redshift-dependent functions?

ntessore commented 1 year ago

cc @arthurmloureiro @mwiet

arthurmloureiro commented 1 year ago

Is Omega_X = omega_X / h**2? I asked you in person, I know it's not... but I think it can be confusing...

ntessore commented 1 year ago

@arthurmloureiro That's a good point. Maybe we should live with the mistakes ~we~ I made and keep the distances functions as they are, but use better names from now on?