search

glassechidna / stackit

Cross-platform CloudFormation CLI tool for easy synchronous and idempotent stack updates
Apache License 2.0
37 stars 7 forks source link

ROLLBACK_COMPLETE with exit code 0? #29

Closed aidansteele closed 5 years ago

aidansteele commented 5 years ago

So I've realised this problem was only with execute.

As there weren't any "errors" per se, this returns nil:

https://github.com/glassechidna/stackit/blob/8e239981015bdb6389c580bf411dcaf7ce13eb78/pkg/stackit/up.go#L217-L234

The up command has code to return a non-zero exit code:

https://github.com/glassechidna/stackit/blob/8e239981015bdb6389c580bf411dcaf7ce13eb78/cmd/up.go#L104-L106

But execute doesn't:

https://github.com/glassechidna/stackit/blob/8e239981015bdb6389c580bf411dcaf7ce13eb78/cmd/execute.go#L72-L81

As that file no longer exists, I'm going to close this. But we should be mindful of it when re-implementing this functionality in #30