search

glassechidna / zxing-cpp

ZXing C++ Library
Apache License 2.0
610 stars 435 forks source link

Fixed a logic error in Code 39 that was requiring too much quiet zone. #37

Closed davegreco closed 8 years ago

davegreco commented 8 years ago

Porting over a Code39 fix from the Java library. This was causing me a lot of issues detecting certain codes.

Issue in Java library for reference. https://github.com/zxing/zxing/issues/86

davegreco commented 8 years ago

Is anyone monitoring this repo still? I know that you guys forked it to benefit the community I'd be willing to help review stuff if you're willing to share access.

aidansteele commented 8 years ago

Hi Dave,

My apologies for not getting to this sooner. Looks like a useful fix and it would be great to have you onboard helping us improve the repo. We haven't had much time to proactively get this repo up to parity with the upstream Java - if that's something you'd like to work on, absolutely go for it!

EDIT: I'm not sure if you got an email from GitHub, but I also added you as a contributor.

davegreco commented 8 years ago

Thank you! I completely understand, no need to apologize. That is why I offered to help. I would love to see this at parity. I'll see what I can do to help.

On Mar 29, 2016, at 4:06 PM, Aidan Steele notifications@github.com wrote:

Hi Dave,

My apologies for not getting to this sooner. Looks like a useful fix and it would be great to have you onboard helping us improve the repo. We haven't had much time to proactively get this repo up to parity with the upstream Java - if that's something you'd like to work on, absolutely go for it!

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub