search

glassechidna / zxing-cpp

ZXing C++ Library
Apache License 2.0
598 stars 435 forks source link

Some adoptions from the java zxing #46

Closed SebastianGoebel closed 7 years ago

SebastianGoebel commented 7 years ago

Sorry, especially the first commit is a little bit messed up, because it consists of several changes (replacing integer shift operations, Code 128 FNC 4 support, some bugfixes (code 39 checksum) etc.. But everything is well tested and nearly everything is a direct adaption from the java version.

Benjamin-Dobell commented 7 years ago

Looks pretty good in general.

There's a few places where you've accidentally added some trailing white-space and you've been slightly inconsistent in your if statement formatting etc. I'll give you an opportunity to clean that up if you're bothered. However, this pull request is already a net gain in terms of code quality, so I'm pretty happy to merge this in a day or so regardless.

SebastianGoebel commented 7 years ago

Thanks, I cleaned up a little bit.